Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): handle parsing json schema type arrays from openapi specs #4565

Merged
merged 3 commits into from
Sep 6, 2024
Merged

fix(cli): handle parsing json schema type arrays from openapi specs #4565

merged 3 commits into from
Sep 6, 2024

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Sep 6, 2024 •
edited
Loading

The Fern OpenAPI importer now handles importing an array for the type key.

  User: 
    properties: 
      name: 
        type: ["string"]
      id: 
        type: ["string", "number"]

dsinghvi
dsinghvi commented Sep 6, 2024
View reviewed changes
packages/cli/openapi-parser/src/schema/convertSchemas.ts
} else {
schema.oneOf.push(...schema.type);
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core change

@dsinghvi dsinghvi force-pushed the dsinghvi/handle-type-array branch from c2e61ef to b453f40 Compare September 6, 2024 15:46
@dsinghvi dsinghvi merged commit 14a7c18 into main Sep 6, 2024
33 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/handle-type-array branch September 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armandobelardo armandobelardo armandobelardo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsinghvi @armandobelardo